Rename nbytes widgets #4878
Rename nbytes widgets #4878
Conversation
There was a problem hiding this comment.
Big +1 here, this is a good change.
I expect this will break the Jupyter Lab Extension downstream. There is a default list of individual panels which is used if the panel discovery fails.
cc @ian-r-rose
|
In particular I think that changing the button in JLab is what I'm most after here. It always take me a while to find it because I'm always looking for "Worker Memory" |
|
Yeah I totally agree @mrocklin. But I guess we need a related PR to the lab extension to change the default URLs. |
|
Gentle ping for @ian-r-rose |
|
ping @ian-r-rose |
|
Sorry to miss the earlier ping. It's a simple fix to update the names of the default charts, and I'd be happy to do that. But we might consider removing the defaults all-together. They used to be more useful, but today they are mostly used to show the greyed out buttons when no dashboard is connected. When the dashboard is live, it should be able to pick up whatever is provided by the |
|
I've reintroduced the old API endpoints; this should hopefully mean that that this PR can be merged without needing to wait for the matching change in dask-labextension? |
There was a problem hiding this comment.
Awesome thanks @crusaderky, good idea.
I've made a comment on the dask-labextension issue to come back here and remove the backward compatibility again.
|
@mrocklin @jrbourbeau ready for merge |
Sorry, I suppose I was unclear in my comment above and the linked issue. What I meant was: the labextension will already pick up name the name changes that you have made. By reintroducing the old name, it now shows up twice in the button listing: The only time that we'll see the old names is when there is not a cluster connected to the UI (which will be resolved with dask/dask-labextension#198). I think we'll want to remove the duplicated individual plots from e7305ea |
Rename widgets:
Rename URIs:
Closes #4871