Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed deposit retry bug fix #147

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Failed deposit retry bug fix #147

merged 2 commits into from
Jan 15, 2025

Conversation

rpoet-jh
Copy link
Contributor

This PR fixes two bugs:

  • There was a bug where if a failed deposit is retried, and the retry fails, the Deposit status is saved as Submitted instead of Failed. This is fixed.
  • There is a scenario where a Deposit from the deployment tests may not have a RepositoryCopy. This was causing a NPE when deleting deployment test data. This is fixed.

There are few other minor cleanup changes made too.

@rpoet-jh rpoet-jh self-assigned this Jan 15, 2025
@rpoet-jh rpoet-jh requested a review from markpatton January 15, 2025 15:25
@rpoet-jh rpoet-jh linked an issue Jan 15, 2025 that may be closed by this pull request
Failure of retry failed deposits leaves deposit in submitted status eclipse-pass/main#1110
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

markpatton
markpatton approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the cleanups make sense.

@rpoet-jh rpoet-jh merged commit adea58a into main Jan 15, 2025
3 checks passed
@rpoet-jh rpoet-jh deleted the rdp-1110-dep-retry-bug branch January 16, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markpatton markpatton markpatton approved these changes

Assignees

@rpoet-jh rpoet-jh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure of retry failed deposits leaves deposit in submitted status
2 participants
@rpoet-jh @markpatton