Revert "Revert "Compositor: Add fade-in animation"" #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenemter
approved these changes
Feb 9, 2024
|
@vjr Do you have any glitches with |
|
@lenemter no glitches with master. Note I only get the glitch with this fade in code on an AMD RX 580 GPU on my desktop PC, it works fine on my laptop though. It could just be an external issue maybe amdgpu driver or Mesa etc so it's ok to merge this pr. |
lenemter
deleted the
revert-701-revert-697-lenemter/compositor-animate-launch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #701
Okay so this actually made things worse for me somehow and @vjr commented on another PR:
So I don't think this caused the dark screen issue thing