Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options: Modernize API for C++17 #1858

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Conversation

mwestphal
Copy link
Contributor

No description provided.

@mwestphal mwestphal requested a review from Meakk January 2, 2025 22:07
Copy link

github-actions bot commented Jan 2, 2025

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.69%. Comparing base (c2529be) to head (e7cca0c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1858   +/-   ##
=======================================
  Coverage   95.69%   95.69%           
=======================================
  Files         125      125           
  Lines        9890     9890           
=======================================
  Hits         9464     9464           
  Misses        426      426           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

library/src/options.cxx Show resolved Hide resolved
@mwestphal mwestphal merged commit 7945233 into f3d-app:master Jan 3, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants