--[BE] - Miscellaneous minor refactors and cleanup #2516
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR will contain various minor refactors and cleanup that I find as I complete other BE work that may be thematically orthogonal to the purpose of that work.
An important issue this PR addresses is that the python tests will currently abort if Habitat-sim is compiled with audio support. This is due to the import of habitat_sim in conftest.py causing an invalid free() unless the python quaternion library is imported first. This is discussed in this issue. Until a reason for this aberrant behavior can be determined, quaternion will be imported here so tests and examples don't fail.
NOTE : There is still an ongoing issue with running python tests with the audio subsystem enabled during compilation, where a greedy path without any action noise is perceived somehow as being a PyCapsule object; addressing that is beyond the scope of this PR.
How Has This Been Tested
locally c++ and python tests
Types of changes
Checklist