Add precision inherition for when generating stream clone #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmitrevs
reviewed
Nov 27, 2023
jmitrevs
reviewed
Nov 27, 2023
jmitrevs
added
please test
jmitrevs
reviewed
Dec 4, 2023
hls4ml/__init__.py
Outdated
| @@ -22,3 +22,8 @@ def reseed(newseed): | |||
| torch.manual_seed(newseed) | |||
| except ImportError: | |||
| print('\nPyTorch seed not set') | |||
| seed = 42 | |||
There was a problem hiding this comment.
I think this is leftover code from testing
jmitrevs
reviewed
Dec 8, 2023
hls4ml/__init__.py
Outdated
| @@ -22,3 +24,5 @@ def reseed(newseed): | |||
| torch.manual_seed(newseed) | |||
| except ImportError: | |||
| print('\nPyTorch seed not set') | |||
|
|
|||
| os.environ['RANDOM_SEED'] = f'{newseed}' | |||
There was a problem hiding this comment.
Why do we need to set the environment variable?
There was a problem hiding this comment.
No. I have been using these lines since a while ago, but it seems they are not doing anything, at least with recent versions of tensorflows.
jmitrevs
added
please test
jmitrevs
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A# Description
Based on #906
When creating cloned streams, use the precision of the stream being cloned. Currently, the precision is
model_defaultwithout any special tweak.Type of change
Tests
test/pytest/test_stream_clone.pyMerged with tests from #906.
Checklist
pre-commiton the files I edited or added.