-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FCE-423, FCE-298: Propose updated way of configuring video quality in SDKs; Re-think default activeEncodings settings in SDK; FCE-1032: Fix stopCapture #281
Conversation
cfdb717
to
0fc8b05
Compare
be186b7
to
662f2a0
Compare
…pdate-simulcast-config
662f2a0
to
ee10165
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go 👍
// iOS has a limit of 3 hardware encoders | ||
// 3 simulcast layers + 1 screen share layer = 4, which is too much |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just thinking - do we still know that this limit applies on latest iOS version? If not, maybe we should investigate it again 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created an issue!
https://linear.app/swmansion/issue/FCE-1033
const defaultSimulcastConfig = () => | ||
({ | ||
enabled: false, | ||
}) satisfies SimulcastConfig; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is philosophical question: should satisfies
be used, or just type variable as () => SimulcastConfig
🤔
(in the end, it does not really matter here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, it doesn't really matter. The advantage of using satisfies instead of a type is that you preserve the actual value.
So if you type is
type Something = { something: string}
and you create an object
const test = { something: 'test'} satisfies Something
You still retail the autocompletion when using test.something
as "test", whereas with type annotation it's just string.
So in our case the user would now that the default value is always false.
Description
Motivation and Context
How has this been tested?
Tested on iOS and Android
Types of changes
not work as expected)
Checklist: