Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only uses AST-parser for .html.erb #543

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Only uses AST-parser for .html.erb #543

merged 1 commit into from
Dec 31, 2023

Conversation

davidwessman
Copy link
Collaborator

glebm
glebm reviewed Dec 30, 2023
View reviewed changes
CHANGES.md Outdated
@@ -1,56 +1,60 @@
## Unreleased

- ErbAst-parser now only used for `*.html.erb`-files, not e.g. `*.js.erb`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why replace all the * with -?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, auto-formatting.. Will fix!

@davidwessman davidwessman force-pushed the 537-do-not-parse-js-with-erb-ast branch from 9abc5b0 to 56bd296 Compare December 30, 2023 15:55
@davidwessman
Copy link
Collaborator Author

@glebm Restored the CHANGES.md-formatting

@glebm glebm merged commit d2e38db into glebm:main Dec 31, 2023
4 of 6 checks passed
@davidwessman davidwessman deleted the 537-do-not-parse-js-with-erb-ast branch May 3, 2024 19:16
@gregorbg gregorbg mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glebm glebm glebm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent and unrelated error messages when modifying code
2 participants
@davidwessman @glebm