-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project level auto destroy setting #1011
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 1419 Passed, 153 Skipped, 16m 19.85s Total Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some manual testing using the examples/ files provided and from functionality looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
If you can squash some of these commits that would be helpful. Thank you. |
Co-authored-by: Sebastian Rivera <[email protected]>
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Description
Add project level changes to allow changes to the auto destroy / ephemeral workspace settings on a project level. We also need a setting (
inherits_project_auto_destroy
) on the workspace to let us see whether or not the workspace currently uses the setting from the project.Testing plan
envchain <namespace> go test -run "TestProjects.*"
External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.