Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(user-svc): implement ReadPublicProfile #484

Merged
merged 2 commits into from
Oct 22, 2023
Merged

feat(user-svc): implement ReadPublicProfile #484

merged 2 commits into from
Oct 22, 2023

Conversation

MaxSchaefer
Copy link
Member

Which issues does this pull request close?

closes #

[OPTIONAL] Give testing instructions to reviewers

@MaxSchaefer MaxSchaefer self-assigned this Oct 22, 2023
@MaxSchaefer MaxSchaefer requested a review from a team as a code owner October 22, 2023 19:10
@MaxSchaefer MaxSchaefer requested review from FoseFx and Paul-B98 and removed request for a team October 22, 2023 19:10
@felixevers felixevers mentioned this pull request Oct 22, 2023
Merged
felixevers
felixevers approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@felixevers felixevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess // TODO auth 😁

@MaxSchaefer
Copy link
Member Author

I guess // TODO auth 😁

Good guess 😅, but nope :) Its a public profile

@MaxSchaefer MaxSchaefer force-pushed the issue/x-implement-read-public-profile branch from e5144cd to 681e6eb Compare October 22, 2023 19:20
@felixevers
Copy link
Member

I guess // TODO auth 😁

Good guess 😅, but nope :) Its a public profile

True, but probably only "public" in orga scope... Right? We're not Trello...

@MaxSchaefer MaxSchaefer merged commit 3d20029 into main Oct 22, 2023
12 checks passed
@MaxSchaefer MaxSchaefer deleted the issue/x-implement-read-public-profile branch October 22, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixevers felixevers felixevers approved these changes

@FoseFx FoseFx Awaiting requested review from FoseFx FoseFx is a code owner automatically assigned from helpwave/backend

@Paul-B98 Paul-B98 Awaiting requested review from Paul-B98 Paul-B98 is a code owner automatically assigned from helpwave/backend

Assignees

@MaxSchaefer MaxSchaefer

Labels
blocker priority: high High priority issue user-svc
Projects
MVP
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxSchaefer @felixevers