Tool classification cmake #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9and3
requested changes
Jan 15, 2024
assets/config.yml
Outdated
Comment on lines
27
to
33
| - 0.485 | ||
| - 0.456 | ||
| - 0.406 | ||
| classifierStd: | ||
| - 0.229 | ||
| - 0.224 | ||
| - 0.225 | ||
| - 0.229 | ||
| - 0.224 | ||
| - 0.225 |
There was a problem hiding this comment.
Please keep the same indentation as before, here is one space less.
There was a problem hiding this comment.
Oops! Sorry! Fixed the config file indentation in d546ef3. Please check it out ! :)
| if not os.path.isfile(args.config): | ||
| _log_error("The path to the config file is not valid.") | ||
| sys.exit() | ||
|
|
There was a problem hiding this comment.
Here it would be worth to catch the error if ai/torchscripts/labels.txt exists since it is a manually-added file.
There was a problem hiding this comment.
Hey ! I am catching the error in the except. So if the file does not exist or the path is wrong, it will be caught! Please, have a look. I also added the success log in 2270968.
|
Hey @9and3 ! Checked on NUC, everything works ok! the branch can be merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a CMake script that executes a Python script (load_labels_2_config.py). This script automatically updates classifier labels in assets/config.yml file by parsing them from a labels.txt file.