-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add INN synonym type #150
Add INN synonym type #150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matentzn there are already many very specific synonyms floating around in OBO world, and they need just as much standardization love as the others. If there's a specific issue with using a hierarchy to group synonym types, then I can remove this, but the point is that there are several other chemical synonym types that are relevant including the ones discussed in #148 and more (e.g., IUPAC) |
@mcourtot might be able to comment in the mean time |
Inn sub chemicalsyntype sub oio:synonymtype - that ok for the current obo format parser? |
If you want to move this forward you have three options:
|
@matentzn you hashtag handled me :p. you know that I will always choose the option that gets the PR in fastest. I removed the nested hierarchy term and updated the description of the PR accordingly. We can move the discussion about adding structure within this hierarchy to a new issue. |
This PR can be merged by anyone from Wednesday 10am PT and is open for reviews until then. |
7fa7ba2
into
information-artifact-ontology:master
Closes #149
This PR adds a synonym type International Nonproprietary Name (OMO:0003010) This is mapped in the SSSOM file to the ChEBI hash URI http://purl.obolibrary.org/obo/chebi#INN
One question for @matentzn: I would like to add a synonym for this synonym type for its abbreviation (INN). Is it more work than its worth to extend the template to enable this?