Remove ICE (IAO_0000030) as a subclass of GDC (BFO_0000031) #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changed to draft as @alanruttenberg says this is somehow deliberate in IAO. Not sure what this is doing asserted in omo-edit.owl though. Anyways, I cant help solving this now anymore, @sebastianduesing you will have to bring this up with Bjoern to find a solution and James can make the necessary edits here once consensus is reached. |
|
@matentzn Understood, we'll work on that. Thanks for checking it out! |
zhengj2007
approved these changes
Aug 30, 2024
jamesaoverton
approved these changes
Sep 16, 2024
|
I believe that the concerns on #177 have been addressed. Jie and I have approved. Nico is on personal leave. @zhengj2007 are you comfortable merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #177
I dont see what business OMO has to make that assertion. Maybe @zhengj2007 knows?