Skip to content

examples don't seem to use panic! or unwrap anymore (#240) #119

examples don't seem to use panic! or unwrap anymore (#240)

examples don't seem to use panic! or unwrap anymore (#240) #119

Triggered via push January 27, 2024 08:18
Status Success
Total duration 3m 2s
Artifacts

check.yml

on: push
stable / fmt
11s
stable / fmt
nightly / doc
33s
nightly / doc
ubuntu / stable / features
28s
ubuntu / stable / features
Matrix: clippy
Matrix: msrv
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
taken reference of right operand: src/key.rs#L212
warning: taken reference of right operand --> src/key.rs:212:9 | 212 | String::new() + &self + rhs | ^^^^^^^^^^^^^^^^----- | | | help: use the right value directly: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `#[warn(clippy::op_ref)]` on by default
deref which would be done by auto-deref: src/session.rs#L818
warning: deref which would be done by auto-deref --> src/session.rs:818:55 | 818 | let body = match serde_json::from_str(&*body)? { | ^^^^^^ help: try: `&body` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `#[warn(clippy::explicit_auto_deref)]` on by default
the borrowed expression implements the required traits: src/session.rs#L749
warning: the borrowed expression implements the required traits --> src/session.rs:749:70 | 749 | base64::engine::general_purpose::STANDARD.encode(&format!( | ______________________________________________________________________^ 750 | | "{}:{}", 751 | | url.username(), 752 | | url.password().unwrap_or("") 753 | | )) | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default help: change this to | 749 ~ base64::engine::general_purpose::STANDARD.encode(format!( 750 + "{}:{}", 751 + url.username(), 752 + url.password().unwrap_or("") 753 ~ )) |
taken reference of right operand: src/key.rs#L212
warning: taken reference of right operand --> src/key.rs:212:9 | 212 | String::new() + &self + rhs | ^^^^^^^^^^^^^^^^----- | | | help: use the right value directly: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `#[warn(clippy::op_ref)]` on by default
deref which would be done by auto-deref: src/session.rs#L818
warning: deref which would be done by auto-deref --> src/session.rs:818:55 | 818 | let body = match serde_json::from_str(&*body)? { | ^^^^^^ help: try: `&body` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `#[warn(clippy::explicit_auto_deref)]` on by default
the borrowed expression implements the required traits: src/session.rs#L749
warning: the borrowed expression implements the required traits --> src/session.rs:749:70 | 749 | base64::engine::general_purpose::STANDARD.encode(&format!( | ______________________________________________________________________^ 750 | | "{}:{}", 751 | | url.username(), 752 | | url.password().unwrap_or("") 753 | | )) | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default help: change this to | 749 ~ base64::engine::general_purpose::STANDARD.encode(format!( 750 + "{}:{}", 751 + url.username(), 752 + url.password().unwrap_or("") 753 ~ )) |
stable / clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
stable / clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
beta / clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
beta / clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/