examples don't seem to use panic! or unwrap anymore (#240) #119
GitHub Actions / clippy
succeeded
Jan 27, 2024 in 0s
clippy
3 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 3 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.75.0 (82e1608df 2023-12-21)
- cargo 1.75.0 (1d8b05cdd 2023-11-20)
- clippy 0.1.75 (82e1608 2023-12-21)
Annotations
Check warning on line 212 in src/key.rs
github-actions / clippy
taken reference of right operand
warning: taken reference of right operand
--> src/key.rs:212:9
|
212 | String::new() + &self + rhs
| ^^^^^^^^^^^^^^^^-----
| |
| help: use the right value directly: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
= note: `#[warn(clippy::op_ref)]` on by default
Check warning on line 818 in src/session.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> src/session.rs:818:55
|
818 | let body = match serde_json::from_str(&*body)? {
| ^^^^^^ help: try: `&body`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
Check warning on line 753 in src/session.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> src/session.rs:749:70
|
749 | base64::engine::general_purpose::STANDARD.encode(&format!(
| ______________________________________________________________________^
750 | | "{}:{}",
751 | | url.username(),
752 | | url.password().unwrap_or("")
753 | | ))
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
help: change this to
|
749 ~ base64::engine::general_purpose::STANDARD.encode(format!(
750 + "{}:{}",
751 + url.username(),
752 + url.password().unwrap_or("")
753 ~ ))
|
Loading