Remove Pending flag from skipped tests #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing Pending flag from 2162 regarding issue resolved [1] and 2165 regarding issue resolved [2]. Those tests were flaky due to an issue with how the manager pods reported readiness, this caused the manager-pods to raise "..connection refused" errors right after deletion. Now that [3] is merged we can continue to use these tests. [1] k8snetworkplumbingwg#104 [2] k8snetworkplumbingwg#105 [3] k8snetworkplumbingwg#124 Signed-off-by: Or Mergi <[email protected]>
|
/lgtm |
kubevirt-bot
added
lgtm
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RamLavi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR remove Pending flag form
2162and2165tests.These tests were flaky due to an issue with how the manager pods
reported readiness, this caused the manager-pods to raise
connection refusederrors right after deletion.We deploy the manager pods with Deployment thus after deletion the pods
will be be created again right away, and so are the certs by the cert-manager used
in KubeMacPollManager.
The manager-pods will report readiness before the certs are ready,
and eventually cause connection refused error (due to absent cert).
Now that #124 is merged we can continue to use these tests.
Special notes for your reviewer:
Release note: