Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Pending flag from skipped tests #138

Merged
merged 1 commit into from
May 10, 2020
Merged

Remove Pending flag from skipped tests #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/virtual_machines_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,8 +266,8 @@ var _ = Describe("Virtual Machines", func() {
Expect(err).ToNot(HaveOccurred())
})
})
//2162 test postponed due to issue: https://github.com/k8snetworkplumbingwg/kubemacpool/issues/104
PContext("When trying to create a VM after all MAC addresses in range have been occupied", func() {
//2162
Context("When trying to create a VM after all MAC addresses in range have been occupied", func() {
It("should return an error because no MAC address is available", func() {
err := initKubemacpoolParams("02:00:00:00:00:00", "02:00:00:00:00:01")
Expect(err).ToNot(HaveOccurred())
Expand All @@ -289,8 +289,8 @@ var _ = Describe("Virtual Machines", func() {
Expect(err).To(HaveOccurred())
})
})
//2165 test postponed due to issue: https://github.com/k8snetworkplumbingwg/kubemacpool/issues/105
PContext("when trying to create a VM after a MAC address has just been released duo to a VM deletion", func() {
//2165
Context("when trying to create a VM after a MAC address has just been released duo to a VM deletion", func() {
It("should re-use the released MAC address for the creation of the new VM and not return an error", func() {
err := initKubemacpoolParams("02:00:00:00:00:00", "02:00:00:00:00:02")
Expect(err).ToNot(HaveOccurred())
Expand Down