fix(developer): debug flag for compiling keyboards #9901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #9885. The 'Include Debug Info' flag was being ignored by the kmc wrapper.
keymanapp-test-bot
bot
added
has-user-test
user-test-required
User Test ResultsTest specification and instructions
|
8 tasks
Test Results
|
keymanapp-test-bot
bot
removed
the
user-test-required
jahorton
approved these changes
Nov 1, 2023
… fix/developer/9885-debug-flag-not-working-in-tike
Base automatically changed from
fix/developer/9889-compiler-crash-without-project
to
master
November 2, 2023 03:49
mcdurdin
deleted the
fix/developer/9885-debug-flag-not-working-in-tike
branch
8 tasks
|
Changes in this pull request will be available for download in Keyman version 17.0.204-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9885.
The 'Include Debug Info' flag was being ignored by the kmc wrapper.
User Testing
TEST_DEBUG_FLAG_ON: In Keyman Developer, open a keyboard project and open the keyboard source file. Ensure that 'Keyboard'/'Include Debug Information' is checked. Compile the keyboard and press F5. The debugger should open.
TEST_DEBUG_FLAG_OFF: In Keyman Developer, open a keyboard project and open the keyboard source file. Ensure that 'Keyboard'/'Include Debug Information' is not checked. Compile the keyboard and press F5. The debugger should not open, and instead an error 'You must include debug information to start the debugger...' should be displayed.