fix(developer): raise error if virtual key in context string #9908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7880. Virtual keys have never been allowed in context. This should be an error in a keyboard. Note: virtual keys in output are officially unsupported but still kinda sorta a little bit work in Windows -- but I doubt they will ever be officially supported. Also includes small side journey to tidy up names and constants for two other tests (error_duplicate_group and error_duplicate_store).
User Test ResultsTest specification and instructions User tests are not required |
Closed
8 tasks
mcdurdin
commented
Nov 2, 2023
| @@ -54,15 +54,22 @@ describe('CompilerMessages', function () { | |||
| // CERR_DuplicateGroup | |||
|
|
|||
| it('should generate CERR_DuplicateGroup if the kmn contains two groups with the same name', async function() { | |||
| await testForMessage(this, ['invalid-keyboards', 'cerr_duplicate_group.kmn'], 0x302071); //TODO: consolidate messages from kmcmplib, CompilerMessages.CERR_DuplicateGroup | |||
| await testForMessage(this, ['invalid-keyboards', 'error_duplicate_group.kmn'], KmnCompilerMessages.ERROR_DuplicateGroup); //TODO: consolidate messages from kmcmplib, CompilerMessages.CERR_DuplicateGroup | |||
There was a problem hiding this comment.
Suggested change
| await testForMessage(this, ['invalid-keyboards', 'error_duplicate_group.kmn'], KmnCompilerMessages.ERROR_DuplicateGroup); //TODO: consolidate messages from kmcmplib, CompilerMessages.CERR_DuplicateGroup | |
| await testForMessage(this, ['invalid-keyboards', 'error_duplicate_group.kmn'], KmnCompilerMessages.ERROR_DuplicateGroup); |
mcdurdin
commented
Nov 2, 2023
Comment on lines
7
to
12
| store (consonant) "lmn" | ||
| store (sylcons) U+1E37 U+1E43 U+1E47 | ||
|
|
||
|
|
||
| c ERROR_VirtualKeyInContext | ||
| [K_BKQUOTE] + any(consonant) > index (sylcons, 2) |
There was a problem hiding this comment.
Suggested change
| store (consonant) "lmn" | |
| store (sylcons) U+1E37 U+1E43 U+1E47 | |
| c ERROR_VirtualKeyInContext | |
| [K_BKQUOTE] + any(consonant) > index (sylcons, 2) | |
| c ERROR_VirtualKeyInContext | |
| [K_BKQUOTE] + 'a' > 'b' |
mcdurdin
commented
Nov 2, 2023
| @@ -1316,6 +1316,9 @@ KMX_BOOL CheckContextStatementPositions(PKMX_WCHAR context) { | |||
| AddWarningBool(CWARN_IfShouldBeAtStartOfContext); | |||
| } | |||
| break; | |||
| case CODE_EXTENDED: | |||
| AddCompileError(CERR_VirtualKeyInContext); | |||
There was a problem hiding this comment.
Update the function comment to note this test.
Base automatically changed from
fix/developer/enable-and-update-tests
to
master
November 2, 2023 03:53
mcdurdin
deleted the
fix/developer/7880-error-if-virtual-key-in-context
branch
|
Changes in this pull request will be available for download in Keyman version 17.0.204-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7880.
Virtual keys have never been allowed in context. This should be an error in a keyboard. Note: virtual keys in output are officially unsupported but still kinda sorta a little bit work in Windows -- but I doubt they will ever be officially supported.
Also includes small side journey to tidy up names and constants for two other tests (error_duplicate_group and error_duplicate_store).
@keymanapp-test-bot skip