Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

threshold-based segmentation, coiled for N4/thresholding, BIDS app CLI, gubra and marmoset template, #18

Open
wants to merge 44 commits into
base: main
Choose a base branch
from

Conversation

akhanf
Copy link
Member

@akhanf akhanf commented Nov 21, 2024

This working branch has a lot of new features and fixes

major updates:

  • threshold-based segmentation workflow
    • performs field fraction quantifacation using otsu thresholding on N4 corrected data
  • use of coiled for dask rules
    • applying N4 and performing thresholding now done with coiled
    • TODO in future PR: make coiled optional
  • configured the BIDS app CLI (for spimquant console script), so we can use this instead of updating the config
    • TODO in future PR: add more CLI options for setting things like level, stain etc..
  • adds marmoset template (MBMv3)

To do before merging:

  • finish adding in Gubra template (was too large, need to incorporate downloading from zenodo into the workflow)
  • make a PR for snakebids (to use pybids 0.18.0, and the relative path fix)
  • make a release for latest zarrnii changes and point to that
  • maybe do the optional TODO's mentioned in the features above

akhanf added 30 commits October 13, 2024 23:46
involves minor fixes to snakebids and pybids
was not using stain_for_reg for penalty mask
- now we don't need to downsample z and determine what downsampling
rates to use
- this is done internally in ZarrNii depending on the specification of
the level

- also added rules for getting fieldfrac roi atlas space images
also started updating cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant