Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: fix BlkIOReconcile plugin not using WaitForCacheSync method correctly to synchronize PVC resources #2205

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Wangmin362
Copy link

Ⅰ. Describe what this PR does

Add the statesInformer.HasSynced method to wait for the PVC resource synchronization to complete.

If the WaitForCacheSync method is not passed a second parameter, the return value is always true

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

…t for the PVC resource synchronization to complete.

If the WaitForCacheSync method is not passed a second parameter, the return value is always true
@saintube
Copy link
Member

@Wangmin362 Thanks for your nice catch! Please check the failure reason of the DCO check before the PR is merging.
image

@songtao98
Copy link
Contributor

songtao98 commented Sep 12, 2024

/lgtm
Please check the DCO information and sign off your commit to make it mergable @Wangmin362

@songtao98 songtao98 added the lgtm label Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.74%. Comparing base (4f16162) to head (23249e0).

Files with missing lines Patch % Lines
...ordlet/qosmanager/plugins/blkio/blkio_reconcile.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2205      +/-   ##
==========================================
+ Coverage   67.72%   67.74%   +0.01%     
==========================================
  Files         446      446              
  Lines       42697    42697              
==========================================
+ Hits        28918    28923       +5     
+ Misses      11257    11255       -2     
+ Partials     2522     2519       -3     
Flag Coverage Δ
unittests 67.74% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube
Copy link
Member

saintube commented Nov 26, 2024

@Wangmin362 Please remember to sign-off your commit to resolve the DCO check, so that we can merge your PR.
e.g. git commit -asm "<commit message>"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants