Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: fix BlkIOReconcile plugin not using WaitForCacheSync method correctly to synchronize PVC resources #2205

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

koordlet: fix BlkIOReconcile plugin not using WaitForCacheSync method correctly to synchronize PVC resources #2205

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68a5ab1
koordlet(qos-manager): Add the statesInformer.HasSynced method to wai…
Sep 11, 2024
23249e0
koordlet: fix TestBlkIOReconcile_reconcile unit test, add implementat…
Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/koordlet/qosmanager/plugins/blkio/blkio_reconcile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ func New(opt *framework.Options) framework.QOSStrategy {

func (b *blkIOReconcile) init(stopCh <-chan struct{}) error {
b.executor.Run(stopCh)
if !cache.WaitForCacheSync(stopCh) {

if !cache.WaitForCacheSync(stopCh, b.statesInformer.HasSynced) {
return fmt.Errorf("%s: timed out waiting for pvc caches to sync", BlkIOReconcileName)
}
return nil
Expand Down
Loading