Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: strip trailing whitespaces from gitignore.io responses #216

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tomkarw
Copy link
Contributor

@tomkarw tomkarw commented Mar 11, 2024

gitignore.io sometimes returns files with trailing whitespaces at the end of lines. This causes issues when editors remove the whitespaces on formatting, causing autogenerated parts of .gitignore file to change and fail kraken check.

Closes #81.

@tomkarw tomkarw self-assigned this Mar 11, 2024
@tomkarw tomkarw force-pushed the strip-trailing-whitespaces-from-gitignore-io-response branch from 2259e7f to 0ff83ef Compare March 11, 2024 13:35
gitignore.io sometimes returns files with trailing whitespaces at the end of lines.
This causes issues when editors remove the whitespaces on formatting,
causing autogenerated parts of .gitignore file to change and fail kraken check.
@tomkarw tomkarw force-pushed the strip-trailing-whitespaces-from-gitignore-io-response branch from 0ff83ef to c2707a0 Compare March 11, 2024 17:06
@NiklasRosenstein
Copy link
Contributor

As discussed offline, the issue with the Icon line is that it's intentionally followed by a carriage-return. But we should probably just consider throwing out the gitignore.io stuff again and go with a simpler set of well-defined Gitignore lines instead.

@NiklasRosenstein
Copy link
Contributor

NiklasRosenstein commented May 23, 2024

Hey @tomkarw 👋 Would you still like to work on this, and update this MR and replace the gitignore.io stuff with a curated list of Gitignore lines?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trim trailing whitespace for gitignore tokens from gitignore.io
2 participants