Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: strip trailing whitespaces from gitignore.io responses #216

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: strip trailing whitespaces from gitignore.io responses #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changelog/_unreleased.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
[[entries]]
id = "bf3a15ca-a70d-442e-a8bc-2092c71ac08b"
type = "fix"
description = "strip trailing whitespaces from gitignore.io responses"
author = "@tomkarw"
issues = [
"https://github.com/tomkarw/kraken/issues/81",
]
7 changes: 6 additions & 1 deletion kraken-build/src/kraken/std/git/gitignore/gitignore_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,12 @@ def gitignore_io_fetch(tokens: Sequence[str]) -> str:
url = GITIGNORE_API_URL + ",".join(tokens)
response = http.get(url)
response.raise_for_status()
return response.text.replace("\r\n", "\n")
lines = response.text.replace("\r\n", "\n").split("\n")
# gitignore.io sometimes returns files with trailing whitespaces at the end of lines
# this causes issues when editors remove the whitespaces on formatting, causing autogenerated
# parts of .gitignore file to change and fail kraken check
lines = [line.rstrip() for line in lines]
return "\n".join(lines)


def gitignore_io_fetch_cached(tokens: Sequence[str], backfill: bool) -> str:
Expand Down
Loading