Skip to content

feat: add resourceVersion for pod, svc and eps #1434

feat: add resourceVersion for pod, svc and eps

feat: add resourceVersion for pod, svc and eps #1434

Triggered via pull request January 15, 2025 06:22
Status Failure
Total duration 6m 19s
Artifacts

ci.yml

on: pull_request
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

16 errors and 5 warnings
test (1.20): pkg/registry/hpaaggregator/metrics/resource/pod_test.go#L342
cannot use fakePodLister{…} (value of type fakePodLister) as aggregatedlister.AggregatedLister value in struct literal: fakePodLister does not implement aggregatedlister.AggregatedLister (wrong type for method ByNamespace)
test (1.20): pkg/registry/hpaaggregator/metrics/resource/pod_test.go#L414
cannot use podLister (variable of type fakePodLister) as aggregatedlister.AggregatedLister value in argument to NewPodMetrics: fakePodLister does not implement aggregatedlister.AggregatedLister (wrong type for method ByNamespace)
test (1.20)
Process completed with exit code 2.
test (1.19): pkg/registry/hpaaggregator/metrics/resource/pod_test.go#L342
cannot use fakePodLister{…} (value of type fakePodLister) as type aggregatedlister.AggregatedLister in struct literal:
test (1.19): pkg/registry/hpaaggregator/metrics/resource/pod_test.go#L414
cannot use podLister (variable of type fakePodLister) as type aggregatedlister.AggregatedLister in argument to NewPodMetrics:
test (1.19)
Process completed with exit code 2.
lint: pkg/registry/hpaaggregator/aggregation/forward/endpointSlice.go#L17
17-206 lines are duplicate of `pkg/registry/hpaaggregator/aggregation/forward/pod.go:17-208` (dupl)
lint: pkg/registry/hpaaggregator/aggregation/forward/service.go#L17
17-206 lines are duplicate of `pkg/registry/hpaaggregator/aggregation/forward/endpointSlice.go:17-206` (dupl)
lint: pkg/util/aggregatedlister/endpointSlice.go#L17
17-145 lines are duplicate of `pkg/util/aggregatedlister/pod.go:17-145` (dupl)
lint: pkg/util/aggregatedlister/service.go#L17
17-145 lines are duplicate of `pkg/util/aggregatedlister/endpointSlice.go:17-145` (dupl)
lint: pkg/registry/hpaaggregator/aggregation/forward/pod.go#L26
File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/kubewharf/kubeadmiral) --custom-order (gci)
lint: pkg/util/aggregatedlister/pod.go#L22
File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/kubewharf/kubeadmiral) --custom-order (gci)
lint: pkg/registry/hpaaggregator/aggregation/rest.go#L27
File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/kubewharf/kubeadmiral) --custom-order (gci)
lint: pkg/registry/hpaaggregator/metrics/resource_metrics.go#L20
File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/kubewharf/kubeadmiral) --custom-order (gci)
lint: pkg/registry/hpaaggregator/aggregation/forward/endpointSlice.go#L77
string `get` has 4 occurrences, make it a constant (goconst)
lint: pkg/registry/hpaaggregator/aggregation/forward/endpointSlice.go#L79
string `list` has 4 occurrences, make it a constant (goconst)
typos
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
test (1.20)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
verify-codegen
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
test (1.19)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636