Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support treeland platform for wmHelper #279

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

18202781743
Copy link
Contributor

@18202781743 18202781743 commented Nov 26, 2024

WindowManager's some interface may be deprecated, like MotifFunctions
and allWindowIdList.
and there is currently no abstraction of platform common
interfaces.

pms: BUG-287901

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Nov 26, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#279
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Nov 26, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#279
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Nov 26, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#279
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Nov 27, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#279
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Nov 27, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#279
WindowManager's some interface may be deprecated, like MotifFunctions
and allWindowIdList.
and there is currently no abstraction of platform common
interfaces.

pms: BUG-287901
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Nov 27, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#279
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • DWindowManagerHelper::instance()函数中,treelandWMHGlobal被直接返回,但没有检查其是否为空或有效。
  • DWindowManagerHelper::hasBlurWindow()DWindowManagerHelper::hasComposite()DWindowManagerHelper::hasNoTitlebar()函数中,直接调用treelandWMHGlobal->方法,但没有检查treelandWMHGlobal是否为空或有效。
  • TreelandWindowManagerHelper类中的hasBlurWindow()hasComposite()hasNoTitlebar()方法直接返回PersonalizationManager::instance()->isSupported(),没有考虑到可能的其他状态或条件。
  • TreelandWindowManagerHelper类中的connect语句使用了Lambda表达式,但没有检查PersonalizationManager::instance()是否为空或有效。

是否建议立即修改:

  • 应该立即检查Q_GLOBAL_STATIC宏创建的全局静态对象是否为空或有效,以避免潜在的空指针解引用问题。
  • TreelandWindowManagerHelper类中,应该添加适当的错误处理或日志记录,以便在PersonalizationManager::instance()为空或无效时能够及时发现并处理。
  • 对于connect语句,应该添加对PersonalizationManager::instance()的空值检查,以确保连接不会因为无效的实例而失败。

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit fed4aae into linuxdeepin:master Nov 27, 2024
21 of 24 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6gui that referenced this pull request Nov 27, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants