Fixes for AREF GDS parser #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A preview of is uploaded and can be seen here: ✨ https://lip6.github.io/coriolis/pull/126/ ✨ Changes may take a few minutes to propagate. Since this is a preview of production, content with |
jpc-lip6
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: orientation in case of xReflect
There was a problem in case of 90 and 270 angle as rows become columns and columns become rows.
Fix: made steps as vectors, so column step could be actually vertical and row step could be horizontal. This simplified the code without need of swapping number of rows and columns or other axes related variables.