Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for AREF GDS parser #126

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Fixes for AREF GDS parser #126

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14ad4d6
Fixed AREF origin and dx, dy calculations.
lanserge Feb 5, 2024
008563a
Fixed AREF orientation for transformation in case of xReflection
lanserge Feb 5, 2024
18875ee
Fixed AREF vertical and horizontal steps
lanserge Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
127 changes: 57 additions & 70 deletions crlcore/src/ccore/gds/GdsParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1350,9 +1350,9 @@ namespace {
string masterName;
uint16_t columns = 0;
uint16_t rows = 0;
DbU::Unit dx = 0;
DbU::Unit dy = 0;
vector<Point> arrayArea;
Point vx, vy;
Point origin;
Transformation::Orientation orient = Transformation::Orientation::ID;

if (_record.isELFLAGS()) { _stream >> _record; }
if (_record.isPLEX ()) { _stream >> _record; }
Expand All @@ -1373,6 +1373,27 @@ namespace {
cdebug_tabw(101,-1);
return _validSyntax;
}
if (_angle == 90.0) {
orient = Transformation::Orientation::R1;
} else if (_angle == 180.0) {
orient = Transformation::Orientation::R2;
} else if (_angle == 270.0) {
orient = Transformation::Orientation::R3;
} else if (_angle != 0.0) {
cerr << Warning( "GdsStream::readAref(): Unsupported angle %d.2 for AREF (Instance) of \"%s\""
, _angle, masterName.c_str() ) << endl;
}
if (_xReflection) {
switch ( orient ) {
case Transformation::Orientation::ID: orient = Transformation::Orientation::MY; break;
case Transformation::Orientation::R1: orient = Transformation::Orientation::XR; break;
case Transformation::Orientation::R2: orient = Transformation::Orientation::MX; break;
case Transformation::Orientation::R3: orient = Transformation::Orientation::YR; break;
default:
cerr << Warning( "GdsStream::readAref(): Unsupported MX+Orientation (%s) combination for AREF (Instance) of \"%s\""
, getString(orient).c_str(), masterName.c_str() ) << endl;
}
}
}

if (_record.isCOLROW()) {
Expand All @@ -1395,37 +1416,40 @@ namespace {
if (_record.isXY()) {
if (_cell) {
DbU::Unit oneGrid = DbU::fromGrid( 1 );
vector<size_t> offgrids;
const vector<int32_t> coordinates = _record.getInt32s();
for ( size_t i=0 ; i<coordinates.size() ; i += 2 ) {
arrayArea.push_back( Point( coordinates[i ]*_scale
, coordinates[i+1]*_scale ) );
if ( (arrayArea.back().getX() % oneGrid) or (arrayArea.back().getX() % oneGrid) ) {
offgrids.push_back( i );
}
if (coordinates.size() != 6) {
_validSyntax = false;
cdebug_tabw(101,-1);
return _validSyntax;
}

if (not offgrids.empty()) {
size_t offgrid = 0;
ostringstream m;
for ( size_t i=0 ; i<arrayArea.size() ; ++i ) {
if (i) m << "\n";
m << " | " << arrayArea[i];
if ((offgrid < offgrids.size()) and (i == offgrid)) {
m << " offgrid";
++offgrid;
}
}
cerr << Error( "GdsStream::readAref(): Offgrid XY points (foundry grid: %s).\n"
"%s"
, DbU::getValueString(oneGrid).c_str()
, m.str().c_str() ) << endl;
}
origin.setX(coordinates[0] * _scale);
origin.setY(coordinates[1] * _scale);
if ( (origin.getX() % oneGrid) or (origin.getY() % oneGrid) ) {
cerr << Error( "GdsStream::readAref(): Offgrid (%s, %s) origin point (foundry grid: %s).\n"
, DbU::getValueString(origin.getX()).c_str()
, DbU::getValueString(origin.getY()).c_str()
, DbU::getValueString(oneGrid).c_str() ) << endl;
}
else {
cdebug_log(101,0) << "arrayOrigin: " << origin << endl;
}
vx.setX((coordinates[2] * _scale - origin.getX()) / columns);
vx.setY((coordinates[3] * _scale - origin.getY()) / columns);
vy.setX((coordinates[4] * _scale - origin.getX()) / rows);
vy.setY((coordinates[5] * _scale - origin.getY()) / rows);
cdebug_log(101,0) << "vx=("
<< DbU::getValueString(vx.getX())
<< DbU::getValueString(vx.getY()) << ")" << endl;
cdebug_log(101,0) << "vy=("
<< DbU::getValueString(vy.getX())
<< DbU::getValueString(vy.getY()) << ")" << endl;
if (not vx.getX() and not vx.getY() and (columns > 1))
cerr << Error( "GdsStream::readAref(): Null dx, but more than one column (%d)."
, columns ) << endl;
if (not vy.getX() and not vy.getY() and (rows > 1))
cerr << Error( "GdsStream::readAref(): Null dy, but more than one row (%d)."
, rows ) << endl;
}
cdebug_log(101,0) << "arrayArea:" << endl;
cdebug_log(101,0) << "[0] " << arrayArea[0] << endl;
cdebug_log(101,0) << "[1] " << arrayArea[1] << endl;
cdebug_log(101,0) << "[2] " << arrayArea[2] << endl;
_stream >> _record;
} else {
_validSyntax = false;
Expand All @@ -1434,48 +1458,11 @@ namespace {
}

if (_cell) {
Transformation::Orientation orient = Transformation::Orientation::ID;
if (_angle == 90.0) {
orient = Transformation::Orientation::R1;
} else if (_angle == 180.0) {
orient = Transformation::Orientation::R2;
} else if (_angle == 270.0) {
orient = Transformation::Orientation::R3;
} else if (_angle != 0.0) {
cerr << Warning( "GdsStream::readAref(): Unsupported angle %d.2 for AREF (Instance) of \"%s\""
, _angle, masterName.c_str() ) << endl;
}

if (_xReflection) {
switch ( orient ) {
case Transformation::Orientation::ID: orient = Transformation::Orientation::MY; break;
case Transformation::Orientation::R1: orient = Transformation::Orientation::YR; break;
case Transformation::Orientation::R2: orient = Transformation::Orientation::MX; break;
case Transformation::Orientation::R3: orient = Transformation::Orientation::XR; break;
default:
cerr << Warning( "GdsStream::readAref(): Unsupported MX+Orientation (%s) combination for AREF (Instance) of \"%s\""
, getString(orient).c_str(), masterName.c_str() ) << endl;
}
}
Transformation arrayTransf ( 0, 0, orient );
for( auto &pt: arrayArea)
pt = arrayTransf.getPoint(pt);
dx = (arrayArea[1].getX() - arrayArea[0].getX()) / columns;
dy = (arrayArea[2].getY() - arrayArea[0].getY()) / rows;
cdebug_log(101,0) << "dx=" << DbU::getValueString(dx) << endl;
cdebug_log(101,0) << "dy=" << DbU::getValueString(dy) << endl;
if (not dx and (columns > 1))
cerr << Error( "GdsStream::readAref(): Null dx, but more than one column (%d)."
, columns ) << endl;
if (not dy and (rows > 1))
cerr << Error( "GdsStream::readAref(): Null dy, but more than one row (%d)."
, rows ) << endl;
for ( uint32_t column=0 ; column < (uint32_t)columns ; ++column ) {
for ( uint32_t row=0 ; row < (uint32_t)rows ; ++row ) {
DbU::Unit xpos = arrayArea[0].getX() + column*dx;
DbU::Unit ypos = arrayArea[0].getY() + row *dy;
DbU::Unit xpos = origin.getX() + column*vx.getX() + row*vy.getX();
DbU::Unit ypos = origin.getY() + column*vx.getY() + row*vy.getY();
Transformation itemTransf = Transformation( xpos, ypos, orient );
//arrayTransf.applyOn( itemTransf );

cdebug_log(101,0) << "column=" << column
<< " row=" << row
Expand Down
Loading