fix: Better element ID naming for disambiguation (fixes #74)

[ngdangtu-vn]

Summary

Suggest a new name for template ID in simple-template example.

Related issues

Fixes #74

Related content pull request

Later...

[ngdangtu-vn]

@bsmth I would like a feedback about the name. I try to go as simple as possible. It shouldn't change to much but still distinguishable.

[bsmth]

Hi there, sorry I forgot to reply. I've added myself as a reviewer so I don't forget.

[bsmth]

(minor one, it's flagged here as no newline at end of file)

[bsmth]

Hi @ngdangtu-vn what do you think about these changes? 😄 Some comments for you to have a look at. Thanks!

[ngdangtu-vn]

I'm so sorry, I thought I left feedback already. Turn out I didn't :))

I personally don't mind to use shorter name. However, because this example will be used across the MDN doc as small pieces (not a whole example), I decided to go with more semantic than short words.

What do you think?

[bsmth]

I'm so sorry, I thought I left feedback already. Turn out I didn't :))

Not a problem!

I personally don't mind to use shorter name. However, because this example will be used across the MDN doc as small pieces (not a whole example), I decided to go with more semantic than short words.

What do you think?

Yes, I see what you mean. What about custom-paragraph (to get rid of my in this case)?

[ngdangtu-vn]

What about custom-paragraph (to get rid of my in this case)?

Yup, that's better.

[bsmth]

What about custom-paragraph (to get rid of my in this case)?

Yup, that's better.

Nice, I've edited the suggestions if you want to have a look 👀

[bsmth]

Thanks a lot! This looks good to me, I think we can merge and create a PR in mdn/content to update the code and prose there to reflect the naming change!

[bsmth]

Actually I'll hold off on merging until we're happy with the content PR. The pages that need an update are in the linked issue, as far as I can see.

[ngdangtu-vn]

@bsmth So for now, we agree with the new name for the template tag ID and starting to update the content on other MDN pages. Could you confirm if I understand correctly? If so, I'll start on update the tag ID on other MDN pages :)

[bsmth]

@bsmth So for now, we agree with the new name for the template tag ID and starting to update the content on other MDN pages. Could you confirm if I understand correctly? If so, I'll start on update the tag ID on other MDN pages :)

Yes! That sounds good, when you are ready with changes, you can tag me in the PR and I will happily review! Thank you

[bsmth]

Let's get it merged 🚢