Single system/user installer for windows

[kkocdko]

Related to #122698

Inno Setup already provides PrivilegesRequiredOverridesAllowed=dialog and other useful functions to support combine system(admin)/user(non-admin) installer. However, the biggest problem is, VSCode currently uses different AppId for system and user installer.

vscode/build/gulpfile.vscode.win32.js

Lines 71 to 74 in 91fbddd

	return cb => {
	const x64AppId = target === 'system' ? product.win32x64AppId : product.win32x64UserAppId;
	const arm64AppId = target === 'system' ? product.win32arm64AppId : product.win32arm64UserAppId;

vscode/build/win32/code.iss

Lines 7 to 10 in 91fbddd

	[Setup]
	AppId={#AppId}
	AppName={#NameLong}
	AppVerName={#NameVersion}

So, after this change (combine system/user installer) is made, one of these two types of existing users needs to do uninstall first?

But, I still think that this change is worth it. Providing a single installer is the most popular way, like Python, provides a single installer for both system/user install modes, this can reduce user confusion, and, save some CDN costs for Microsoft. LOL.

And, there's another option, keeping the user-only installer, but turn system installer into universal one.

Tips about build installer:

npm run gulp vscode-win32-x64-inno-updater
npm run gulp vscode-win32-x64-system-setup

[kkocdko]

Needs more work: The "Add to Path" option not perfect yet.

[kkocdko]

I found this: https://stackoverflow.com/a/16005826/ . I'll try it.

[leg9hu]

Core play help centre

[kkocdko]

[Setup]
UsePreviousPrivileges=no
AppId={code:GetAppId}

The AppId with code needs UsePreviousPrivileges=no, this cause the slient update to be visable. VSCodeSetup.exe /VERYSILENT /MERGETASKS=!runcode.

IMO, for this restriction, we needs our own system/user detection and choose logic. Or we needs to do AppId migration.

Even if this restrict in Inno Setup is not exist, how can the installer determind which of system/user should be update if both is installed?

---

Update: this can be solved? by command line option /ALLUSERS and /CURRENTUSER. And we needs to modify updateService.win32.ts. But, we still needs to keep user installer for a while.

[kkocdko]

@joaomoreno Hi, what's your opinion in this? Here are four choices in my view.

• Use AppId={code:GetAppId}, add /ALLUSERS and /CURRENTUSER in updateService.win32.ts for silent update, needs to keep system/user installer for a while, about few months, so that users can update smoothly.
• Use single AppId, choose system installer's AppId, If the installer detected a user installation, prompt to require uninstall old version manually.
• Rewrite the whole installer, use more modern installer solution, like electron/windows-installer or WIX used by Python.
• Do nothing. Remain what it is.

I recommand the first choice. However, the decision is yours and I am not a Microsoft employee. LOL.