Bootstrap 5 Further Progress #992
Conversation
Something to do with the way JS packages are installed.
I'm not sure if it's the right solution or not, but the error goes away
if I do this.
- } else if (typeof exports === 'object') {
+ } else if (typeof module === 'object') {
// Node, CommonJS-like
module.exports = factory(require('jquery'));
|
@mistic100 is the CI here failing for a known reason? |
|
it says it cannot get bootswatch-dist, but this package is for Bootstrap 3 anyway, you probably should remove it |
|
@mistic100 yea i've picked up from where the others left off, it is a bit awkward so a bootstrap-5 branch that we can all commit to could be useful |
|
This branch feels like its in a fairly good place now, although needs further testing.
Feedback / testing would be appreciated from @stephencmorton @dethell if you get any time. I will also test bringing this branch into the project i use it for to test it further. |
|
@liamkeily I'm fine with the work continuing here, although if @mistic100 want's us to be committers to a specific branch that's fine too. Whichever works. I'll go ahead and pull this branch and retest. |
|
This looks good. Checkboxes work, dark mode works, selects work. I can't see any reason not to merge this. Back to you @mistic100 . |
|
Thanks for reviewing @dethell One thing i've wondered is how this will play with the documentation site at https://querybuilder.js.org/demo.html which still uses Bootstrap 3. |
|
I'm fine with any branch as well. If this one is a superset of all the others, I'm good with that. |
|
Oh, the "SRBuilds" id on some of my commits was just me accidentally logged in as my work account. I thought about it and it's ok, I do not need to "git commit --amend --reset-author" or anything like that, my work would be fine with it and it does not reveal I should not. I actually started this because I investigated using jquery-querybuilder for an internal tool. |
|
@mistic100 Do you have any information about how this project is built and published to npm? I wanted to replicate it as closely as possible to make sure it all works but i'm a bit confused by the setup. I just noticed that the dev branch package.json still contains an older version "2.5.0" than the latest release "2.7.0". |
|
That's because the release is done from the master branch. To do a release :
|
|
If I had to really work on this lib (I won't) I would reuse the workflows I created for my other library https://github.com/mistic100/Photo-Sphere-Viewer/tree/main/.github/workflows |
|
I replicated the release process and have been testing this on a real project and fixed a few more minor bugs. It's shaping well, just want to do a bit more testing then might be time to start thinking about tagging up a 3.0.0 pre-release. What do you think @mistic100 ? |
|
Thanks so much @liamkeily . Yeoman's work here. |
|
@stephencmorton yea i'll get rid of those commits for now. I removed it thinking we could just drop it, but then i realised that the demo itself relies on bootstrap-select for language selection. |
|
(We could just change the demo, if that makes the most sense.) |
liamkeily
force-pushed
the
dev-bootstrap-5-liam
branch
from
7fe0a47 to
6289480
Compare
|
Go ahead, squash merge the PR into dev and I'll publish a pre-release to npmjs.org |
…perly when enabled
I've gone ahead and removed the I've also updated screenshots above |
This PR carries on from #988 and #973 to take this a bit further.
Merge request checklist
devand I am issuing the PR todevdistdirectory__localeand__authorfieldsScreenshots Before
Screenshots After