feat: CafeRegisterRequest DTO의 roadAddress 및 phoneNumber 필드 nullable로 수정 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kth990303
approved these changes
Dec 12, 2023
Comment on lines
-18
to
-21
| @NotBlank(message = "1012:공백일 수 없습니다.") | ||
| private String roadAddress; | ||
|
|
||
| @NotBlank(message = "1012:공백일 수 없습니다.") |
There was a problem hiding this comment.
이거 Entity에 nullable=false 라든지, update 로직에 null 미허용 로직이라든지 관련된 코드가 그동안 없었나보네요ㅋㅋ
지금은 nullable 허용돼서 다행이지만, 나중에 컬럼 추가할 때 이런거 좀 더 꼼꼼히 봐줘야겠다는 생각도 들고... 😭 흑흑
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
주의사항