Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CafeRegisterRequest DTO의 roadAddress 및 phoneNumber 필드 nullable로 수정 #144

Merged
merged 1 commit into from
Dec 12, 2023
Merged

feat: CafeRegisterRequest DTO의 roadAddress 및 phoneNumber 필드 nullable로 수정 #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/main/java/mocacong/server/dto/request/CafeRegisterRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@ public class CafeRegisterRequest {
@NotBlank(message = "1012:공백일 수 없습니다.")
private String name;

@NotBlank(message = "1012:공백일 수 없습니다.")
private String roadAddress;

@NotBlank(message = "1012:공백일 수 없습니다.")
Comment on lines -18 to -21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 Entity에 nullable=false 라든지, update 로직에 null 미허용 로직이라든지 관련된 코드가 그동안 없었나보네요ㅋㅋ
지금은 nullable 허용돼서 다행이지만, 나중에 컬럼 추가할 때 이런거 좀 더 꼼꼼히 봐줘야겠다는 생각도 들고... 😭 흑흑

private String phoneNumber;
}