AoE Fix #1912
Open
AoE Fix #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moo-man
reviewed
Apr 10, 2024
| @@ -36,7 +36,11 @@ export default class AbilityTemplate extends MeasuredTemplate { | |||
| { | |||
| if (aoeString.toLowerCase().includes(game.i18n.localize("AoE").toLowerCase())) | |||
| aoeString = aoeString.substring(aoeString.indexOf("(")+1, aoeString.length-1) | |||
|
|
|||
|
|
|||
| let test = game.messages.get(messageId).getTest(); | |||
There was a problem hiding this comment.
This is clunky, the point of the diameter parameter is to be able to configure this behavior. The solution here should be to call the function with the correct diameter argument
There was a problem hiding this comment.
No clue about this, so you can close this one if you want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the AoE button in the overcast section of Spells/Prayers rolls.
The system always applied "diameter" in this AoE, now it will only apply diameter for spells.