Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AoE Fix #1912

Open
wants to merge 1 commit into
base: effect-refactor
Choose a base branch
from
Open

AoE Fix #1912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion modules/system/aoe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,11 @@ export default class AbilityTemplate extends MeasuredTemplate {
{
if (aoeString.toLowerCase().includes(game.i18n.localize("AoE").toLowerCase()))
aoeString = aoeString.substring(aoeString.indexOf("(")+1, aoeString.length-1)


let test = game.messages.get(messageId).getTest();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is clunky, the point of the diameter parameter is to be able to configure this behavior. The solution here should be to call the function with the correct diameter argument

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No clue about this, so you can close this one if you want.

if (!test.spell)
diameter=false

// Prepare template data
const templateData = {
t: "circle",
Expand Down