Mitigate test flakiness

Signed-off-by: methylDragon <[email protected]>
moveit · Dec 30, 2024 · 0c4d4d5 · 0c4d4d5
1 parent 5a40222
commit 0c4d4d5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...ache/test/cache_insert_policies/test_always_insert_never_prune_policy_with_move_group.cpp b/...ache/test/cache_insert_policies/test_always_insert_never_prune_policy_with_move_group.cpp
@@ -149,14 +149,14 @@ TEST_F(MoveGroupFixture, AlwaysInsertNeverPrunePolicyWorks)
     ASSERT_TRUE(move_group_->setPoseTarget(move_group_->getRandomPose()));
     move_group_->constructMotionPlanRequest(msg);
     ret = move_group_->plan(plan);
-  } while (!ret && plan.trajectory.joint_trajectory.points.empty());  // Sometimes the plan fails with the random pose.
+  } while (!ret || plan.trajectory.joint_trajectory.points.empty());  // Sometimes the plan fails with the random pose.
 
   do
   {
     ASSERT_TRUE(move_group_->setPoseTarget(move_group_->getRandomPose()));
     move_group_->constructMotionPlanRequest(another_msg);
     another_ret = move_group_->plan(another_plan);
-  } while (another_msg == msg && !another_ret &&
+  } while (another_msg == msg || !another_ret ||
            another_plan.trajectory.joint_trajectory.points
                .empty());  // Also, sometimes the random pose happens to be the same.
 

diff --git a/...cache/test/cache_insert_policies/test_best_seen_execution_time_policy_with_move_group.cpp b/...cache/test/cache_insert_policies/test_best_seen_execution_time_policy_with_move_group.cpp
@@ -149,14 +149,14 @@ TEST_F(MoveGroupFixture, BestSeenExecutionTimePolicyWorks)
     ASSERT_TRUE(move_group_->setPoseTarget(move_group_->getRandomPose()));
     move_group_->constructMotionPlanRequest(msg);
     ret = move_group_->plan(plan);
-  } while (!ret && plan.trajectory.joint_trajectory.points.empty());  // Sometimes the plan fails with the random pose.
+  } while (!ret || plan.trajectory.joint_trajectory.points.empty());  // Sometimes the plan fails with the random pose.
 
   do
   {
     ASSERT_TRUE(move_group_->setPoseTarget(move_group_->getRandomPose()));
     move_group_->constructMotionPlanRequest(another_msg);
     another_ret = move_group_->plan(another_plan);
-  } while (another_msg == msg && !another_ret &&
+  } while (another_msg == msg || !another_ret ||
            another_plan.trajectory.joint_trajectory.points
                .empty());  // Also, sometimes the random pose happens to be the same.