Fix CMake error when building cached_ik_kinematics_plugin with trac_ik present #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sea-bass
added
the
backport-iron
ChrisThrasher
approved these changes
Oct 10, 2023
sjahr
approved these changes
Oct 10, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2421 +/- ##
=======================================
Coverage 50.87% 50.87%
=======================================
Files 386 386
Lines 31983 31983
=======================================
Hits 16269 16269
Misses 15714 15714 ☔ View full report in Codecov by Sentry. |
henningkayser
pushed a commit
that referenced
this pull request
Oct 24, 2023
…k present (backport #2421) (#2422) (cherry picked from commit e37b956) Co-authored-by: Sebastian Castro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes this build error introduced by #2292, but uncaught because the
trac_ikplugins are not tested in our CI:See this link for details why.