Reduce mutex scope in Servo thread #3259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes occasional main thread starvation caused by repeatedly creating a lock_guard in the servo loop. Fairness is improved by removing the thread sleep rate from the lock scope.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3259 +/- ##
==========================================
- Coverage 45.65% 45.65% -0.00%
==========================================
Files 714 714
Lines 62299 62300 +1
Branches 7532 7531 -1
==========================================
- Hits 28437 28436 -1
- Misses 33694 33696 +2
Partials 168 168 ☔ View full report in Codecov by Sentry. |
AndyZe
approved these changes
Jan 22, 2025
sea-bass
approved these changes
Jan 22, 2025
sea-bass
added
the
backport-jazzy
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
JafarAbdi
approved these changes
Jan 22, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
Fixes occasional main thread starvation caused by repeatedly creating a lock_guard in the servo loop. Fairness is improved by removing the thread sleep rate from the lock scope. (cherry picked from commit b91e529)
sea-bass
pushed a commit
that referenced
this pull request
Jan 22, 2025
(cherry picked from commit b91e529) Co-authored-by: Henning Kayser <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes occasional main thread starvation caused by repeatedly creating a lock_guard in the servo loop. One side effect would be that the pause_servo service would not respond. Fairness is improved by removing the thread sleep rate from the lock scope.