Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Reworked routing for the app #598

Merged
merged 1 commit into from
Nov 2, 2023
Merged

[MNT] Reworked routing for the app #598

merged 1 commit into from
Nov 2, 2023

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Nov 2, 2023

Closes #545

Changes proposed in this pull request:

  • Implemented navigateToPage action
  • Replaced the implicit routing using to prop on buttons with a call to navigateToPage action on click event
  • Updated my_happy_annotation_page e2e test

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for neurobagel-annotator ready!

Name Link
🔨 Latest commit 4c7e7df
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-annotator/deploys/6543d09fd4430000082ff1be
😎 Deploy Preview https://deploy-preview-598--neurobagel-annotator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@rmanaem rmanaem merged commit 3f35c64 into master Nov 2, 2023
7 checks passed
@rmanaem rmanaem deleted the routing-fix branch November 2, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple routing logic
2 participants