Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offshore Gas Drilling and Pumping #2403

Merged
merged 74 commits into from
Jan 18, 2025

Conversation

whatston3
Copy link
Contributor

@whatston3 whatston3 commented Nov 14, 2024

About the PR

The goals of this PR are as follows:

  1. Enable gas transfer between grids.
  2. Add a source of large amounts of gas on the main map.
  3. Remove the dependence on canister spam to buy and sell gases.

Currently, random gas deposits are created when an asteroid is loaded in (players must be close, ~16 m away). These deposits exist underneath the rock (there's a pinpointer to point to gas deposits, if only for debug purposes).

This also adds a drill that extract a fixed amount of gas from the source per atmosphere update, pushing that out into a pipe at a set temperature and maximum pressure.

A set of docking points with pressure pumps are also added to enable the transfer of gases between grids.

TODOS:

  • Automatically enable a minimal atmospherics setup for gas piping from an asteroid to a ship.
    • Minimal setup (drill to pipe to gas port) works fine. Possible issues with more complicated setup.
  • Add a set of controls to remotely access a gas port's controls (setting the pressure, on/off status, and direction).
    • Needs testing, should work.
  • Disable the gaslocks and clear the outlet ports when undocking (controlling contamination)

Why / Balance

This is a first attempt at more involved atmospherics gameplay: this should enable extracting, moving, filtering and processing large quantities of gas outside of expeditions. This should allow for "gas tanker" gameplay, and may be more suitable for supermatter gameplay without the use of gas miners.

How to test

TBD. Fly around, find gas deposits, pump them.

Media

A simple test case - a player on a Gasbender visits an asteroid, finds a gas deposit, and constructs a scaffold to dock with the host ship and extract the resources back to the shuttle (burn chamber used for storage). This exhibits the deposits, miner, and airlocks in use.
image

Requirements

Breaking changes

Changelog

TBD

Copy link
Contributor

github-actions bot commented Nov 14, 2024

RSI Diff Bot; head commit ff41a46 merging into 81dd7c2
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Specific/Atmospherics/deposit.rsi

State Old New Status
deposit Added

Resources/Textures/_NF/Objects/Specific/Atmospherics/extractor.rsi

State Old New Status
base-powered Added
base Added
drill-blocked-unlit Added
drill-empty-unlit Added
drill-low-unlit Added
drill-off Added
drill-on-unlit Added
drill Added
pipe Added

Resources/Textures/_NF/Structures/Machines/computers.rsi

State Old New Status
gas_sale_point Added
generic_keys Added
generic_panel_open Added

Resources/Textures/_NF/Structures/Piping/Atmospherics/gaslock.rsi

State Old New Status
closed Added
closed_unlit Added
panel_open Added
pipeStraight Added
pumpPressure Added
pumpPressureOnIn Added
pumpPressureOnOut Added

Resources/Textures/_NF/Structures/Piping/Atmospherics/portable_gaslock.rsi

State Old New Status
base Added
closed_unlit Added
panel_open Added
pipeStraight Added
pumpPressure Added
pumpPressureOnIn Added
pumpPressureOnOut Added

Resources/Textures/_NF/Structures/Piping/Atmospherics/salepoint.rsi

State Old New Status
base-unlit Added
base Added
docked-unlit Added
on-unlit Added
pipe Added
struts Added

Edit: diff updated after ff41a46

@blackknight954
Copy link
Contributor

Atmos eatin good tonight.

You say a player has to be close to the roid when it spawns to have the deposit appear? or am I reading that wrong.

Will every asteroid have these or only certain asteroids?

@whatston3
Copy link
Contributor Author

Atmos eatin good tonight.

You say a player has to be close to the roid when it spawns to have the deposit appear? or am I reading that wrong.

Will every asteroid have these or only certain asteroids?

Currently not on vgroids, I've got them randomly spawning on all sizes of asteroids (might be worth placing them only on particularly large ones, haven't given it too much thought).

You need to be close to actually have it spawn in, yes, think this should be alright, but if we want to give any sort of "divining equipment", you won't be able to pick out an asteroid that has them at 100-200 m, you'd pretty much need to be on it.

@blackknight954
Copy link
Contributor

Atmos eatin good tonight.
You say a player has to be close to the roid when it spawns to have the deposit appear? or am I reading that wrong.
Will every asteroid have these or only certain asteroids?

Currently not on vgroids, I've got them randomly spawning on all sizes of asteroids (might be worth placing them only on particularly large ones, haven't given it too much thought).

You need to be close to actually have it spawn in, yes, think this should be alright, but if we want to give any sort of "divining equipment", you won't be able to pick out an asteroid that has them at 100-200 m, you'd pretty much need to be on it.

Yeah, Just asking because I've seen asteroids spawn around 120-200 meters away from shuttles at minimum, so not sure how you'd get within 16 meters of the grid as it spawns

@Jakumba
Copy link
Contributor

Jakumba commented Nov 15, 2024

Really cool idea, the more gameplay loops that can be done on the main map instead of being locked on expeditions is grand!

@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Nov 16, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict This PR has conflicts that prevent merging label Nov 16, 2024
@whatston3 whatston3 mentioned this pull request Nov 16, 2024
2 tasks
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

2 similar comments
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@whatston3 whatston3 added S: Awaiting Changes This PR has changes that need to be made before merging S: DO NOT MERGE and removed S: Needs Review This PR is awaiting reviews labels Jan 17, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Jan 17, 2025
@github-actions github-actions bot removed the S: Merge Conflict This PR has conflicts that prevent merging label Jan 17, 2025
@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Jan 17, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict This PR has conflicts that prevent merging label Jan 18, 2025
@whatston3 whatston3 added S: Needs Review This PR is awaiting reviews and removed S: Awaiting Changes This PR has changes that need to be made before merging S: DO NOT MERGE labels Jan 18, 2025
@Cheackraze Cheackraze merged commit 30ac7d8 into new-frontiers-14:master Jan 18, 2025
17 of 18 checks passed
@MilonPL MilonPL mentioned this pull request Jan 20, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# FTL Map-POI Map - POI Map-Shuttle Map - Shuttle S: Needs Review This PR is awaiting reviews Sprites UI YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants