feat(TMD-918): Update to newsletter article component logic #3978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lint add missing sections
amerkadicE
force-pushed
the
feat/tmd-918-update-to-newsletter-article-component-logic
branch
from
5ee0e1a to
d5798ef
Compare
|
ibrahim-kurhan
approved these changes
Nov 15, 2024
| @@ -37,6 +37,141 @@ const newslettersBySection = [ | |||
| "https://www.thetimes.co.uk/imageserver/image/methode%2Ftimes%2Fprod%2Fweb%2Fbin%2F306637af-2b6f-48fc-b264-d661b2067818.jpg?resize=800" | |||
| }) | |||
| }, | |||
| { | |||
| section: "environment", | |||
There was a problem hiding this comment.
@amerkadicE just wondering whether these sections actually exist? As far as I was aware it was based on edition sections? Do we need to do some work to change section value to point to primary category?
milanharia-tm
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update to newsletter article component logic
TMD-918
Checklist
Screenshots (if appropriate):
Include screenshots if needed.