Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TMD-918): Update to newsletter article component logic #3978

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
146 changes: 146 additions & 0 deletions packages/article-skeleton/src/contentModifiers/newsletter-puff.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,141 @@ const newslettersBySection = [
"https://www.thetimes.co.uk/imageserver/image/methode%2Ftimes%2Fprod%2Fweb%2Fbin%2F306637af-2b6f-48fc-b264-d661b2067818.jpg?resize=800"
})
},
{
section: "environment",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amerkadicE just wondering whether these sections actually exist? As far as I was aware it was based on edition sections? Do we need to do some work to change section value to point to primary category?

payload: setNewsletterPayload({
code: "TNL-140",
headline: "Environment newsletter",
copy:
"The latest climate news, book and podcast reviews and reasons to be cheerful."
})
},
{
section: "politics",
payload: setNewsletterPayload({
code: "TNL-119",
headline: "Politics newsletter",
copy:
"Our insider's guide to Westminster, plus a rundown of PMQs every Wednesday."
})
},
{
section: "us",
payload: setNewsletterPayload({
code: "TNL-153",
headline: "US Newsletter",
copy:
"A balanced, fair and fact-checked take on global news and culture for our US readers."
})
},
{
section: "fashion",
payload: setNewsletterPayload({
code: "TNL-108",
headline: "Fashion newsletter",
copy:
"Look good and feel great with the latest tips and trends from our fashion team."
})
},
{
section: "beauty",
payload: setNewsletterPayload({
code: "TNL-108",
headline: "Fashion newsletter",
copy:
"Look good and feel great with the latest tips and trends from our fashion team."
})
},
{
section: "food",
payload: setNewsletterPayload({
code: "TNL-106",
headline: "Food Newsletter",
copy:
"Restaurant reviews, insider insights and recipes from the best chefs in the business."
})
},
{
section: "football",
payload: setNewsletterPayload({
code: "TNL-111",
headline: "Football newsletter",
copy:
"Learn something new about the beautiful game with James Gheerbrant's bespoke analysis."
})
},
{
section: "property",
payload: setNewsletterPayload({
code: "TNL-113",
headline: "Property Newsletter",
copy:
"Inside Britain's most exclusive homes, plus what's going on in the property market."
})
},
{
section: "books",
payload: setNewsletterPayload({
code: "TNL-115",
headline: "Books newsletter",
copy:
"News, reviews, author interviews and suggested reads from our literary editors."
})
},
{
section: "theatre",
payload: setNewsletterPayload({
code: "TNL-127",
headline: "Theatre Newsletter",
copy:
"Our chief theatre critic on what to see (and what to miss) in the West End and beyond."
})
},
{
section: "film",
payload: setNewsletterPayload({
code: "TNL-133",
headline: "TV newsletter",
copy:
"What to watch or stream, plus news and reviews from our small-screen experts."
})
},
{
section: "tv",
payload: setNewsletterPayload({
code: "TNL-133",
headline: "TV newsletter",
copy:
"What to watch or stream, plus news and reviews from our small-screen experts."
})
},
{
section: "puzzles",
payload: setNewsletterPayload({
code: "TNL-125",
headline: "Puzzles Newsletter",
copy:
"The best crossword clues and quiz questions, plus insights from our puzzles editor."
})
},
{
section: "travel",
payload: setNewsletterPayload({
code: "TNL-149",
headline: "Travel newsletter",
copy:
"Get inspiration for your next trip and a great deal thanks to our carefully curated offers."
})
},
{
section: "entrepreneurs",
payload: setNewsletterPayload({
code: "TNL-145",
headline: "Entrepreneurs Newsletter",
copy:
"Advice and inspiration for entrepreneurs in The Times Enterprise Network's briefing."
})
},
{
section: "scotland",
payload: setNewsletterPayload({
Expand All @@ -59,6 +194,17 @@ const newslettersBySection = [
"https://www.thetimes.co.uk/imageserver/image/methode%2Ftimes%2Fprod%2Fweb%2Fbin%2Ffd44b15f-2fb8-4e5d-b409-315648b10646.jpg?resize=800"
})
},
{
section: "economics",
payload: setNewsletterPayload({
code: "TNL-107",
headline: "Money newsletter",
copy:
"Personal finance and investment news from our money experts, every Monday.",
imageUri:
"https://www.thetimes.co.uk/imageserver/image/methode%2Ftimes%2Fprod%2Fweb%2Fbin%2Ffd44b15f-2fb8-4e5d-b409-315648b10646.jpg?resize=800"
})
},
{
section: "law",
payload: setNewsletterPayload({
Expand Down