Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: ImageActivity crash after options menu selected #12226

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Fix: ImageActivity crash after options menu selected #12226

merged 1 commit into from
Dec 6, 2023

Conversation

parneet-guraya
Copy link
Contributor

Before

Record_2023-12-04-13-58-18.mp4

After

Record_2023-12-04-13-59-13.mp4
  • Tests written, or not not needed

@alperozturk96
Copy link
Collaborator

/rebase

@alperozturk96 alperozturk96 mentioned this pull request Dec 6, 2023
Merged
1 task
@alperozturk96
Copy link
Collaborator

/backport to stable-3.27

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.28.0 milestone Dec 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Codacy

Lint

TypemasterPR
Warnings7575
Errors99

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness6969
Dodgy code359359
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total552552

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12226.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AndyScherzinger AndyScherzinger merged commit 2b166a8 into master Dec 6, 2023
20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-options-menu branch December 6, 2023 18:37
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 6, 2023
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alperozturk96 alperozturk96 alperozturk96 approved these changes

@JonasMayerDev JonasMayerDev JonasMayerDev approved these changes

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Assignees
No one assigned
Labels
4. to release feedback-requested
Projects
None yet
Milestone
Nextcloud App 3.28.0
Development

Successfully merging this pull request may close these issues.
4 participants
@parneet-guraya @alperozturk96 @JonasMayerDev @AndyScherzinger