Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate featuresets #441

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Separate featuresets #441

merged 2 commits into from
Oct 7, 2024

Conversation

hjkatz
Copy link
Contributor

@hjkatz hjkatz commented Sep 20, 2024

What

Describe what the change is solving

Separate the feature sets into different functions and options.

How

Describe the solution

  • Add feature flags for ingress and gateway
  • Split up featureset registration in main.go

Breaking Changes

Are there any breaking changes in this PR?

@hjkatz hjkatz requested a review from a team as a code owner September 20, 2024 18:10
@github-actions github-actions bot added area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart labels Sep 20, 2024
@hjkatz hjkatz mentioned this pull request Sep 20, 2024
Copy link
Contributor Author

hjkatz commented Sep 20, 2024

@jonstacks @alex-bezek I hope I separated these featuresets at the correct boundaries.

Q. What is the ngrok traffic policy controller and when does it need to be running?

Copy link
Contributor Author

hjkatz commented Sep 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hjkatz and the rest of your teammates on Graphite Graphite

@hjkatz hjkatz changed the base branch from hkatz/healthcheck to graphite-base/441 September 20, 2024 20:01
@hjkatz hjkatz changed the base branch from graphite-base/441 to main September 20, 2024 20:02
Copy link
Contributor Author

hjkatz commented Oct 7, 2024

Merge activity

  • Oct 7, 2:42 PM EDT: @hjkatz started a stack merge that includes this pull request via Graphite.
  • Oct 7, 2:42 PM EDT: @hjkatz merged this pull request with Graphite.

@hjkatz hjkatz merged commit 92082b6 into main Oct 7, 2024
8 checks passed
@hjkatz hjkatz deleted the hkatz/featuresets branch October 7, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants