Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace Helm Values by Feature Set #442

Merged
merged 8 commits into from
Oct 8, 2024
Merged

Conversation

hjkatz
Copy link
Contributor

@hjkatz hjkatz commented Sep 20, 2024

What

Describe what the change is solving

Namespace the feature sets in Helm values

How

Describe the solution

Collect each feature set and put it into a namespaced section:

ingress:
  enabled: true/false
  ...

gateway:
  enabled: true/false
  ...

bindings:
  enabled: true/false
  ...

Breaking Changes

Are there any breaking changes in this PR?

I tried to make this backwards compatible but I suspect it's not 100% due to incompatible DeMorgan logic etc... between desired and expected behaviours.

So here's what's deprecated:

  • Deprecate useExperimentalGatewayApi, instead use gateway.enabled: true
  • Deprecate ingressClass, instead use ingress.ingressClass
  • Deprecate watchNamespace, instead use ingress.watchNamespace
  • Deprecate controllerName, instead use ingress.controllerName

@hjkatz hjkatz requested a review from a team as a code owner September 20, 2024 19:23
@github-actions github-actions bot added the area/helm-chart Issues dealing with the helm chart label Sep 20, 2024
@hjkatz hjkatz mentioned this pull request Sep 20, 2024
Copy link
Contributor Author

hjkatz commented Sep 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hjkatz and the rest of your teammates on Graphite Graphite

@hjkatz hjkatz mentioned this pull request Sep 20, 2024
@hjkatz hjkatz force-pushed the hkatz/featuresets branch 2 times, most recently from 34b344b to b161363 Compare September 20, 2024 20:02
@hjkatz hjkatz force-pushed the hkatz/namespace-helm-values branch from 6f4578e to 95ad275 Compare September 20, 2024 20:02
@github-actions github-actions bot added the area/controller Issues dealing with the controller label Sep 23, 2024
helm/ngrok-operator/values.yaml Show resolved Hide resolved
@hjkatz hjkatz changed the base branch from hkatz/featuresets to graphite-base/442 October 7, 2024 18:42
@hjkatz hjkatz force-pushed the hkatz/namespace-helm-values branch from a8d0d54 to 58399e5 Compare October 7, 2024 18:42
@hjkatz hjkatz changed the base branch from graphite-base/442 to main October 7, 2024 18:43
@hjkatz hjkatz force-pushed the hkatz/namespace-helm-values branch 2 times, most recently from db3a20d to a8d0d54 Compare October 8, 2024 15:14
@hjkatz hjkatz force-pushed the hkatz/namespace-helm-values branch from 48f8ba9 to 3ea0c51 Compare October 8, 2024 15:16
@hjkatz hjkatz enabled auto-merge October 8, 2024 15:16
@hjkatz hjkatz merged commit 9fc7e61 into main Oct 8, 2024
9 checks passed
@hjkatz hjkatz deleted the hkatz/namespace-helm-values branch October 8, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants