-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Namespace Helm Values by Feature Set #442
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
hjkatz
force-pushed
the
hkatz/featuresets
branch
2 times, most recently
from
September 20, 2024 20:02
34b344b
to
b161363
Compare
hjkatz
force-pushed
the
hkatz/namespace-helm-values
branch
from
September 20, 2024 20:02
6f4578e
to
95ad275
Compare
jonstacks
approved these changes
Oct 2, 2024
hjkatz
force-pushed
the
hkatz/namespace-helm-values
branch
from
October 7, 2024 18:42
a8d0d54
to
58399e5
Compare
hjkatz
force-pushed
the
hkatz/namespace-helm-values
branch
2 times, most recently
from
October 8, 2024 15:14
db3a20d
to
a8d0d54
Compare
hjkatz
force-pushed
the
hkatz/namespace-helm-values
branch
from
October 8, 2024 15:16
48f8ba9
to
3ea0c51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/controller
Issues dealing with the controller
area/helm-chart
Issues dealing with the helm chart
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Describe what the change is solving
Namespace the feature sets in Helm values
How
Describe the solution
Collect each feature set and put it into a namespaced section:
Breaking Changes
Are there any breaking changes in this PR?
I tried to make this backwards compatible but I suspect it's not 100% due to incompatible DeMorgan logic etc... between desired and expected behaviours.
So here's what's deprecated:
useExperimentalGatewayApi
, instead usegateway.enabled: true
ingressClass
, instead useingress.ingressClass
watchNamespace
, instead useingress.watchNamespace
controllerName
, instead useingress.controllerName