Remove binding name

[masonj5n]

What

The API for kubernetes bindings is being updated and no longer includes the binding_name field. Instead, kubernetes endpoints will be scoped to the account instead of a specific operator.

How

Removes references to binding_name.

Breaking Changes

The ngrok API for kubernetes bindings itself is breaking with this change so this is just following that.
As far as the operator itself:

• The KubernetesOperatorBinding resource had its Name field removed.
• values.yaml has been updated to no longer include bindings.name

[Alice-Lilith]

🙏 looking forward to not getting my logs spammed with

2025-01-10T00:31:52Z	DEBUG	events	Failed to update KubernetesOperator/ngrok-operator: HTTP 422: The request parameter 'name' is unknown and not expected. The supported fields are: allowed_urls, csr, ingress_endpoint. Please check your API client implementation and review the API documentation: https://ngrok.com/docs/api#api-kubernetes-operators-update. [ERR_NGROK_214]

[jonstacks]

I wonder if we shouldn't leave this field in here but mark it as deprecated and change the validation to optional. The only thing I'm worried about if we remove it right now is if someone deploys this change and then rolls back to a previous version, what happens?

If there aren't a lot of users using bindings right now, I think its a lower risk change.

[masonj5n]

Since we're breaking the API on the hosted side bindings won't work with this field anyway so I don't think it matters too much. Whenever we cut a release with these and a couple other upcoming changes that'll be the first release that works with bindings going forward

[codecov]

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@96ccc03). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
.../controller/ngrok/kubernetesoperator_controller.go	0.00%	4 Missing ⚠️
...ternal/controller/bindings/boundendpoint_poller.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #567   +/-   ##
=======================================
  Coverage        ?   24.11%           
=======================================
  Files           ?       88           
  Lines           ?    12571           
  Branches        ?        0           
=======================================
  Hits            ?     3031           
  Misses          ?     9350           
  Partials        ?      190           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.