-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #19401; fixes #19402; rework Forward declaration and finalizer for ORC #20295
Conversation
44894d8
to
9788f85
Compare
It seems that at the time of For instance type
Object = object
Ref = ref Object
proc delete(x: Ref) It generates a proc delete(x: Ref)
proc deleteFinalizerWrapper(x: var Object) =
delete(x) After some refactorings, it can solve #19231 too |
Thanks for your hard work on this PR! Hint: mm: orc; threads: on; opt: speed; options: -d:release |
…n and finalizer for ORC (nim-lang#20295) * fixes nim-lang#19401; fixes nim-lang#19402; rework Forward declaration and finalizer for ORC * add more tests * give it a name * make more tests * fixes tests * hidden addr for cpp * move code to a function
fixes #19401
fixes #19402
It is a draft because It's the solution I can think of for now. I'm going to examine it tomorrow. At least it works for #19401 and #19402 locally.