Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #22844; uses arrays to store holeyenums for iterations; much more efficient than sets and reasonable for holeyenums #22845

Merged
merged 7 commits into from
Oct 20, 2023
Merged

fixes #22844; uses arrays to store holeyenums for iterations; much more efficient than sets and reasonable for holeyenums #22845

merged 7 commits into from
Oct 20, 2023

Conversation

ringabout
Copy link
Member

fixes #22844

ringabout
ringabout commented Oct 19, 2023
View reviewed changes
lib/system/iterators.nim Outdated Show resolved Hide resolved
@ringabout ringabout closed this Oct 19, 2023
@ringabout ringabout reopened this Oct 19, 2023
ringabout
ringabout commented Oct 19, 2023
View reviewed changes
lib/system/iterators.nim Outdated Show resolved Hide resolved
ringabout
ringabout commented Oct 19, 2023
View reviewed changes
lib/system/iterators.nim Outdated Show resolved Hide resolved
@ringabout ringabout marked this pull request as draft October 20, 2023 00:41
ringabout
ringabout commented Oct 20, 2023
View reviewed changes
lib/system/iterators.nim Outdated Show resolved Hide resolved
@ringabout ringabout changed the title fixes #22844; suppress warnings of iterating sets of holeyenums fixes #22844; uses arrays to store holeyenums for iterations Oct 20, 2023
@ringabout ringabout marked this pull request as ready for review October 20, 2023 01:00
@ringabout ringabout changed the title fixes #22844; uses arrays to store holeyenums for iterations fixes #22844; uses arrays to store holeyenums for iterations (much efficient than sets) Oct 20, 2023
@ringabout ringabout changed the title fixes #22844; uses arrays to store holeyenums for iterations (much efficient than sets) fixes #22844; uses arrays to store holeyenums for iterations (much more efficient than sets) Oct 20, 2023
@ringabout ringabout changed the title fixes #22844; uses arrays to store holeyenums for iterations (much more efficient than sets) fixes #22844; uses arrays to store holeyenums for iterations; much more efficient than sets and reasonable for holeyenums Oct 20, 2023
@Araq Araq merged commit e108780 into devel Oct 20, 2023
22 checks passed
@Araq Araq deleted the ringabout-patch-6 branch October 20, 2023 16:38
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from e108780

Hint: mm: orc; opt: speed; options: -d:release
174728 lines; 9.362s; 769.898MiB peakmem

narimiran pushed a commit that referenced this pull request Apr 18, 2024
@ringabout @narimiran
fixes #22844; uses arrays to store holeyenums for iterations; much mo…
106c7d2 
…re efficient than sets and reasonable for holeyenums (#22845)

fixes #22844

(cherry picked from commit e108780)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enumutils items[HoleyEnum] example code produces "unsafe" warnings
2 participants
@ringabout @Araq