Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #22844; uses arrays to store holeyenums for iterations; much more efficient than sets and reasonable for holeyenums #22845

Merged
merged 7 commits into from
Oct 20, 2023
Merged

fixes #22844; uses arrays to store holeyenums for iterations; much more efficient than sets and reasonable for holeyenums #22845

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
174376b
fixes #22844; suppress warnings of iterating sets of holeyenums
ringabout Oct 19, 2023
9c07541
Update lib/system/iterators.nim
ringabout Oct 19, 2023
c722d6a
adds a test case
ringabout Oct 19, 2023
ec3fea2
Update lib/system/iterators.nim
ringabout Oct 19, 2023
7ea5d7b
Update lib/system/iterators.nim
ringabout Oct 19, 2023
35fd65f
Update lib/system/iterators.nim
ringabout Oct 20, 2023
d2caa94
use arrays instead of sets
ringabout Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/system/iterators.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,10 @@ iterator items*[T](a: set[T]): T {.inline.} =
## able to hold).
var i = low(T).int
while i <= high(T).int:
if T(i) in a: yield T(i)
when not defined(nimHasCastExtendedVm):
ringabout marked this conversation as resolved.
Show resolved Hide resolved
if cast[T](i) in a: yield cast[T](i)
else:
if T(i) in a: yield T(i)
unCheckedInc(i)

iterator items*(a: cstring): char {.inline.} =
Expand Down
Loading