Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Validate ExpiredDeprecationErrors #857

Merged
merged 3 commits into from
Jan 7, 2020

Conversation

effigies
Copy link
Member

@effigies effigies commented Jan 7, 2020

  • Checks for ExpiredDeprecationError for:
    • ArrayProxy.header
    • SpatialImage.get_shape()
    • SpatialImage.to_files()
    • SpatialImage.to_filespec()
    • SpatialImage.filespec_to_files()
    • SpatialImage.from_files()
    • MincImage
    • MincFile
    • volumeutils.can_cast
    • volumeutils.calculate_scale
    • volumeutils.scale_min_max

Also makes a copy of volumeutils.calculate_scale in the tests, as it's used to validate other methods.

Fixes #854.

@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #857 into maint/3.0.x will decrease coverage by 0.39%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           maint/3.0.x     #857     +/-   ##
==============================================
- Coverage        90.09%   89.69%   -0.4%     
==============================================
  Files               96       96             
  Lines            12416    12422      +6     
  Branches          2186     2187      +1     
==============================================
- Hits             11186    11142     -44     
- Misses             881      935     +54     
+ Partials           349      345      -4
Impacted Files Coverage Δ
nibabel/volumeutils.py 84.13% <ø> (-8.52%) ⬇️
nibabel/pkg_info.py 84.61% <100%> (+2.79%) ⬆️
nibabel/filebasedimages.py 85.8% <0%> (-2.59%) ⬇️
nibabel/dataobj_images.py 94.02% <0%> (-1.5%) ⬇️
nibabel/arrayproxy.py 99.25% <0%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d3e817...cabfc81. Read the comment docs.

@effigies effigies force-pushed the fix/expired_deprecations branch from 92fea73 to 3c00929 Compare January 7, 2020 15:48
@effigies
Copy link
Member Author

effigies commented Jan 7, 2020

Failed test to be resolved in #858.

@effigies effigies merged commit a80cb3c into nipy:maint/3.0.x Jan 7, 2020
@effigies effigies deleted the fix/expired_deprecations branch January 8, 2020 23:18
@effigies effigies added this to the 3.0.1 milestone Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant